0000103: multi stack support for ecmd ipstats not working

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000103

[ethersex] Bug

minor

always

2010-06-14 13:29

2010-06-14 16:20

Reporter

murdok

View Status

public

Assigned To

stettberger

Priority

normal

Resolution

fixed

Status

resolved

Summary

0000103: multi stack support for ecmd ipstats not working

Description

in parser for ecmd ipstats is wrong imlementation of multi stack support

with multiple protos enabled the ipstats parsers always prints for all interfaces with values from the current active uip_stack.

I think first try was on switch of uip_stack_set_active with cmd[1] as interface param, but this won't work (yes, i tried it ;-).
I for myself found a workaround with redifnition of used access macros for i.e. uip_hostaddr etc.

see patch for idea:

--- ethersex/protocols/uip/ipstats.c 2010-06-03 15:51:34.000000000 +0200
+++ ethersex_patched/protocols/uip/ipstats.c 2010-06-14 13:29:09.000000000 +0200
@@ -39,8 +39,15 @@
     cmd[2] = 0; /* counter for output lines for an interface */
   }
   uint8_t tmp;
-#ifdef MULTISTACK_SUPPORT
- uip_stack_set_active(cmd[1]);
+#ifdef UIP_MULTI_STACK
+ #undef uip_hostaddr
+ #define uip_hostaddr (* (uip_stack[cmd[1]].uip_hostaddr))
+ #undef uip_netmask
+ #define uip_netmask (* (uip_stack[cmd[1]].uip_netmask))
+ #undef uip_prefix_len
+ #define uip_prefix_len (* (uip_stack[cmd[1]].uip_prefix_len))
+ #undef uip_stat
+ #define uip_stat (* (uip_stack[cmd[1]].uip_stat))
#endif

   enum {

Additional Information

Tags

No tags attached.

Attached Files

Relationships

Notes
(0000100) stettberger (manager) 2010-06-14 16:20	Thank you for reporting. Fixed as proposed

Issue History
Date Modified	Username	Field	Change
2010-06-14 13:29	murdok	New Issue
2010-06-14 16:20	stettberger	Note Added: 0000100
2010-06-14 16:20	stettberger	Assigned To	=> stettberger
2010-06-14 16:20	stettberger	Status	new => resolved
2010-06-14 16:20	stettberger	Resolution	open => fixed

Mantis 1.1.6[^]